-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Excessive memory usage for SPA where unload hooks keep accumulating #2311 #2312
Conversation
MSNev
commented
Mar 20, 2024
- Rework Asynchronous notification handling
shared/AppInsightsCore/Tests/Unit/src/ApplicationInsightsCore.Tests.ts
Outdated
Show resolved
Hide resolved
|
||
export class GlobalTestHooks { | ||
|
||
public registerTests() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is using a "hack" of our current test infrastructure to "set" some global configuration that will affect "ALL" tests that follow the initialization. (which is why this was added as the "first" item of every tests bundle.
Of note, is that IF any test also changes / sets / calls the test hook it will "replace" and invalidate this setting (as this is currently a single value, not a list of callbacks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They also needed to be created / added here as the "common" test infrastructure does not have access to the main "Application Insights" code to be able to add code specific "hooks"
…ting #2311 - Rework Asynchronous notification handling
d8f1728
to
df29fb0
Compare